cache for sqlite method calls to prevent duplicate writes #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a cache for saveNestedDataHash calls to prevent duplicate writes. Add a metrics counter for the number of duplicate saveNestedDataHash calls. In an environment with ~830 calls to saveNestedDataHash per second after 7 minutes of operation(cache entry TTL), the amount of cached keys was ~349k, with a total of ~33MB of data stored in the cache. Total amount of duplicated calls was 1428.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #207 +/- ##
===========================================
- Coverage 70.13% 70.09% -0.05%
===========================================
Files 32 32
Lines 7834 7877 +43
Branches 438 429 -9
===========================================
+ Hits 5494 5521 +27
- Misses 2340 2356 +16 ☔ View full report in Codecov by Sentry. |
karlprieb
changed the title
WalkthroughWalkthroughThe changes introduce caching mechanisms in the Changes
Possibly related PRs
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
djwhitt
reviewed
Sep 18, 2024
karlprieb
force-pushed
the
PE-6724-dedup-data-db-inserts
branch
from
cd55758
to
9a4e827
Compare
djwhitt
reviewed
Sep 19, 2024
src/database/standalone-sqlite.ts
Outdated
| @@ -2924,6 +2968,17 @@ export class StandaloneSqliteDatabase | |||
| parentId: string; | |||
| dataOffset: number; | |||
| }): Promise<void> { | |||
| const key = `${hash}:${parentId}`; | |||
|
|
|||
| if (this.saveNestedDataHashCache.get(key)) { | |||
There was a problem hiding this comment.
PiKNiK testing matches your test results, @karlprieb. We see some bursts of duplicates, but overall there aren't many here. Let's remove the deduplication here and save some memory.
djwhitt
reviewed
Sep 19, 2024
djwhitt
requested changes
Sep 19, 2024
djwhitt
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a cache for saveNestedDataHash calls to prevent duplicate writes. Add a metrics counter for the number of duplicate saveNestedDataHash calls.
In an environment with ~830 calls to saveNestedDataHash per second after 7 minutes of operation(cache entry TTL), the amount of cached keys was ~349k, with a total of ~33MB of data stored in the cache.
Total amount of duplicated calls was 1428.